Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

629 no support for the mysql connector python library in version 900 #688

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Oct 25, 2024

Update import for new mysql-connector-python version and unpin the version.
The mysql connector will be eventually removed, but this is required now, since trivy finds a vulnerability in the old version, which was pinned before this pull request.

@ppcad ppcad requested a review from dtrai2 October 25, 2024 12:24
@ppcad ppcad self-assigned this Oct 25, 2024
@ppcad ppcad linked an issue Oct 25, 2024 that may be closed by this pull request
@ppcad ppcad marked this pull request as draft October 25, 2024 12:28
@ppcad ppcad marked this pull request as ready for review October 25, 2024 12:39
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that was an easy fix indeed! Can you please fix the pinning to accommodate the CVE though, and also add a changelog entry? :)

pyproject.toml Outdated Show resolved Hide resolved
ppcad and others added 2 commits October 28, 2024 06:48
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
@ppcad ppcad requested a review from dtrai2 October 28, 2024 05:58
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ekneg54 ekneg54 merged commit 499ff55 into main Oct 28, 2024
13 checks passed
@ekneg54 ekneg54 deleted the 629-no-support-for-the-mysql-connector-python-library-in-version-900 branch October 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for the mysql-connector-python library in version 9.0.0
3 participants